mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 24658: Updated equality check for CommandInfo.
Date Wed, 13 Aug 2014 18:11:42 GMT


> On Aug. 13, 2014, 6:10 p.m., Vinod Kone wrote:
> > src/common/type_utils.cpp, lines 76-86
> > <https://reviews.apache.org/r/24658/diff/1/?file=659441#file659441line76>
> >
> >     Hmm. I think the order is important for argv right?
> >     
> >     e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1.

Good catch!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/#review50478
-----------------------------------------------------------


On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24658/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 5:49 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee 
> 
> Diff: https://reviews.apache.org/r/24658/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message