mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 24464: Redirect docker logs
Date Wed, 13 Aug 2014 06:38:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50426
-----------------------------------------------------------


Just realized. What's the recover story?
1) what if the slave exits, does the log process terminate?
2) if the log process does not terminate, how do we recover it (so that we can destroy it
later)?

- Jie Yu


On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 10:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24464
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
>   src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
>   src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d 
> 
> Diff: https://reviews.apache.org/r/24464/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message