mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 24631: Refactored the protobuf message comparison logic.
Date Wed, 13 Aug 2014 05:32:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24631/#review50407
-----------------------------------------------------------

Ship it!


Not exactly the most efficient way of doing this, but let's profile and optimize later if
necessary! ;-)

- Benjamin Hindman


On Aug. 13, 2014, 5:17 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24631/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 5:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. We need update CommandInfo comparison code to deal with the new fields.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee 
> 
> Diff: https://reviews.apache.org/r/24631/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message