mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 24464: Redirect docker logs
Date Fri, 08 Aug 2014 17:09:02 GMT


> On Aug. 8, 2014, 4:41 p.m., Jie Yu wrote:
> > src/docker/docker.cpp, line 512
> > <https://reviews.apache.org/r/24464/diff/2/?file=655523#file655523line512>
> >
> >     return checkError(cmd, s.get());

I don't think I want to checkError since it already reads stderr, however docker logs pipes
the stderr of the docker container to its process so I'll end up re-reading the whole stderr
of the container.
I think I'll just check status.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50042
-----------------------------------------------------------


On Aug. 7, 2014, 9:56 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 9:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Redirect docker logs
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
>   src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
> 
> Diff: https://reviews.apache.org/r/24464/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message