mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Review Request 24485: Allowed flags to load from a configure file as defaults.
Date Fri, 08 Aug 2014 00:09:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.


Bugs: MESOS-1651
    https://issues.apache.org/jira/browse/MESOS-1651


Repository: mesos-git


Description
-------

See ticket for details. When parsing flags, users now can specify a file to be used as defaults.
The command line arguments will override the defaults specified in the configure file. The
file is a JSON object:

{
  "flag1" : "string",
  "flag2" : true,
  "flag3" : 10,
  "flag4" : { "a" : 1, "b" : 2}
  ..
}


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
  src/tests/main.cpp 442be51 

Diff: https://reviews.apache.org/r/24485/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message