mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 24286: Do not send invisible resources to the framework.
Date Wed, 06 Aug 2014 03:53:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24286/#review49691
-----------------------------------------------------------

Ship it!


Thanks Jie!


src/master/master.cpp
<https://reviews.apache.org/r/24286/#comment86974>

    I think we've been trying to name these with the _ as a suffix, akin to prime notation:
offer'



src/tests/master_tests.cpp
<https://reviews.apache.org/r/24286/#comment86975>

    Do you need these two? Or can you use the StartSlave() that only takes the flags?
    
    At which point the comment on the last line probably isn't relevant?
    
      Shutdown(); // Must shutdown before 'containerizer' gets deallocated.


- Ben Mahler


On Aug. 6, 2014, 2:31 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24286/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 2:31 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1654
>     https://issues.apache.org/jira/browse/MESOS-1654
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Introduced an optional flag 'visible' for resource. Invisible resources are not exposed
to the framework. The idea is that the master will perform allocation for those resources.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 9bede96 
>   src/tests/master_tests.cpp 9a1a373 
> 
> Diff: https://reviews.apache.org/r/24286/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message