mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yifan Gu" <yi...@mesosphere.io>
Subject Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
Date Tue, 05 Aug 2014 23:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 11:49 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Bugs: MESOS-886
    https://issues.apache.org/jira/browse/MESOS-886


Repository: mesos-git


Description
-------

Added __runTask() to wait for the completion of containerizer->update() and check the result
before sending RunTaskMessage.


Diffs (updated)
-----

  src/slave/slave.hpp c12cd0a 
  src/slave/slave.cpp ef921e1 
  src/tests/slave_tests.cpp 432d8a2 

Diff: https://reviews.apache.org/r/22313/diff/


Testing
-------

SlaveTest, CancelTaskIfContainerizerFails

Which tests that if the containerizer->update() return a Failure, the task won't be launched
and the scheduler will get TASK_LOST.

make check


File Attachments
----------------

framework will exit
  https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
log
  https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log


Thanks,

Yifan Gu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message