mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 24269: Made ephemeral ports a resource and killed private resources.
Date Tue, 05 Aug 2014 00:45:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49539
-----------------------------------------------------------

Ship it!


A follow up to filter 'ephemeral_ports' from offers for this short term fix SGTM, we probably
want to avoid letting frameworks see these since they are ignored by the slave.


include/mesos/mesos.proto
<https://reviews.apache.org/r/24269/#comment86648>

    Since this was never released, and it's a repeated field, we should be able to remove
it. How about commenting it out so that we don't re-use '9'?



include/mesos/resources.hpp
<https://reviews.apache.org/r/24269/#comment86650>

    Did you want a TODO for an EphemeralPorts abstraction that holds the allocation logic?


- Ben Mahler


On Aug. 4, 2014, 10:18 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24269/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 10:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1654
>     https://issues.apache.org/jira/browse/MESOS-1654
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary and ticket for details.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6d4fd14 
>   include/mesos/resources.hpp daaa6bf 
>   src/common/resources.cpp ade2a71 
>   src/slave/containerizer/isolators/network/port_mapping.hpp f75429c 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 8445874 
>   src/slave/flags.hpp 146c401 
>   src/slave/slave.cpp 8e40c5b 
>   src/tests/mesos.cpp 35c94fa 
>   src/tests/port_mapping_tests.cpp 393b578 
> 
> Diff: https://reviews.apache.org/r/24269/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message