Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 873DF11E63 for ; Tue, 29 Jul 2014 14:55:06 +0000 (UTC) Received: (qmail 82029 invoked by uid 500); 29 Jul 2014 14:55:01 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 81964 invoked by uid 500); 29 Jul 2014 14:55:01 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 81945 invoked by uid 99); 29 Jul 2014 14:55:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jul 2014 14:55:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C0B991D90D0; Tue, 29 Jul 2014 14:54:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7486303925553925080==" MIME-Version: 1.0 Subject: Review Request 24057: Help Flag Cleanup From: "Ken Sipe" To: "Adam B" , "Ben Mahler" Cc: "Ken Sipe" , "mesos" Date: Tue, 29 Jul 2014 14:54:47 -0000 Message-ID: <20140729145447.21934.40983@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ken Sipe" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/24057/ X-Sender: "Ken Sipe" Reply-To: "Ken Sipe" X-ReviewRequest-Repository: mesos-git --===============7486303925553925080== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24057/ ----------------------------------------------------------- Review request for mesos, Adam B and Ben Mahler. Repository: mesos-git Description ------- The --help on master and slave have a number of issues which are resolved with this patch. 1. consistency - Path, Location, Where are all used to describe the path of a directory or file. These are cleaned up. 2. zk path for a file must be file:/// not file://. I get that the last / is part of the path, however without an example it can be confusing to newbies 3. --registration_backoff_factor help refers to a register_backoff_factor value which is incorrect. 4. Attribute's notation really needs an example (which is added). Diffs ----- src/logging/flags.hpp 08101b87e5843e8c8f3a74b87d46138a5ff2a97e src/master/flags.hpp 32704ce19c20815315b0f6bc4efc535f01c00c30 src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25 src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb Diff: https://reviews.apache.org/r/24057/diff/ Testing ------- style check, compiling and manual review Thanks, Ken Sipe --===============7486303925553925080==--