Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5979D117A3 for ; Tue, 22 Jul 2014 20:38:15 +0000 (UTC) Received: (qmail 54902 invoked by uid 500); 22 Jul 2014 20:38:15 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 54846 invoked by uid 500); 22 Jul 2014 20:38:15 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 54817 invoked by uid 99); 22 Jul 2014 20:38:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jul 2014 20:38:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0B7B81DB963; Tue, 22 Jul 2014 20:38:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5048581862881876119==" MIME-Version: 1.0 Subject: Re: Review Request 23771: Added a Docker containerizer. From: "Timothy St. Clair" To: "Benjamin Hindman" , "Jie Yu" , "Ian Downes" Cc: "Timothy St. Clair" , "mesos" , "Timothy Chen" Date: Tue, 22 Jul 2014 20:38:02 -0000 Message-ID: <20140722203802.4204.26961@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy St. Clair" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/23771/ X-Sender: "Timothy St. Clair" References: <20140722181255.4203.92162@reviews.apache.org> In-Reply-To: <20140722181255.4203.92162@reviews.apache.org> Reply-To: "Timothy St. Clair" X-ReviewRequest-Repository: mesos-git --===============5048581862881876119== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48402 ----------------------------------------------------------- only 1/2 way through, this may take a bit. src/docker/docker.hpp So imho we should try to match parity with the API where possible, to provide an abstraction which is consistent. https://docs.docker.com/reference/api/docker_remote_api_v1.13/ IMHO - It looks more like a cli wrap vs. docker API abstraction. Perhaps we could open another JIRA after this? src/docker/docker.hpp Graceful termination? How does signal escalation get handled? src/docker/docker.cpp code standard - header ordering. src/docker/docker.cpp This is pretty weird to have here and would only exist on a pre-EL7. All relatively newer distro(s) it would be guaranteed true. Do folks want to support the pre-EL7 route? Because it may kneecap docker. src/docker/docker.cpp Might want to consider placing into a serializable struct. src/docker/docker.cpp See other comment re: shares and groups. src/docker/docker.cpp Input args will need to override defaults re: net, there is a separate JIRA on *this. src/docker/docker.cpp Should this be here? Also manifest constant for the chunck is probably wise for page size. src/docker/docker.cpp It almost seems like at certain points the REST API would be simpler/cleaner. e.g. GET /containers/(id)/json Perhaps we should open a JIRA? src/slave/containerizer/isolators/cgroups/cpushare.cpp Umm this is not always true, it's a weight based on the total across all groups. In systemd land this means promoting docker to a top level group and assigning a weight that has meaning. ref - http://timothysc.github.io/blog/2013/06/14/systemd-cgroup-sla/ - Timothy St. Clair On July 22, 2014, 6:12 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23771/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Docker implementation. > This is all the docker code Ben, I and Yifan worked on excluding the composing containerizer patches. > > > Diffs > ----- > > src/Makefile.am 45afcd1 > src/common/status_utils.hpp 1980551 > src/docker/docker.hpp PRE-CREATION > src/docker/docker.cpp PRE-CREATION > src/examples/docker_no_executor_framework.cpp PRE-CREATION > src/health-check/main.cpp 707810a > src/launcher/executor.cpp 9c80848 > src/linux/cgroups.hpp decad9d > src/linux/cgroups.cpp 6a73dd7 > src/master/master.cpp 251b699 > src/slave/containerizer/containerizer.cpp 1b71f33 > src/slave/containerizer/docker.hpp PRE-CREATION > src/slave/containerizer/docker.cpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp 3f28d85 > src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b > src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 > src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7 > src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35 > src/slave/containerizer/isolators/posix.hpp 17bbd10 > src/slave/flags.hpp 1fe7b7d > src/slave/slave.cpp f42ab60 > src/tests/docker_containerizer_tests.cpp PRE-CREATION > src/tests/docker_tests.cpp PRE-CREATION > src/tests/environment.cpp 434b3f7 > src/tests/flags.hpp a003e7f > src/tests/mesos_test_executor_docker_image/Dockerfile PRE-CREATION > src/tests/mesos_test_executor_docker_image/install.sh PRE-CREATION > src/tests/script.cpp 15a6542 > src/usage/usage.hpp 5a76746 > src/usage/usage.cpp 29014d1 > > Diff: https://reviews.apache.org/r/23771/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============5048581862881876119==--