Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6BC0106F0 for ; Wed, 16 Jul 2014 18:39:17 +0000 (UTC) Received: (qmail 82930 invoked by uid 500); 16 Jul 2014 18:39:12 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 82869 invoked by uid 500); 16 Jul 2014 18:39:12 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 82854 invoked by uid 99); 16 Jul 2014 18:39:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jul 2014 18:39:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5E041DB85A; Wed, 16 Jul 2014 18:38:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0424635426820224306==" MIME-Version: 1.0 Subject: Re: Review Request 23464: Properly iterate through composing containerizers. From: "Jie Yu" To: "Jie Yu" , "Ian Downes" Cc: "Benjamin Hindman" , "mesos" Date: Wed, 16 Jul 2014 18:38:59 -0000 Message-ID: <20140716183859.24005.25551@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/23464/ X-Sender: "Jie Yu" References: <20140714223120.24005.80756@reviews.apache.org> In-Reply-To: <20140714223120.24005.80756@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos-git --===============0424635426820224306== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23464/#review47927 ----------------------------------------------------------- Would you mind explaining why do this change? Does the previous version has a bug? Also, I think we need some tests for the new composing containerizer? - Jie Yu On July 14, 2014, 10:31 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23464/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 10:31 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1527 > https://issues.apache.org/jira/browse/MESOS-1527 > > > Repository: mesos-git > > > Description > ------- > > See summary and dependent review 23462. > > > Diffs > ----- > > src/slave/containerizer/composing.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > > --===============0424635426820224306==--