Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF22B11881 for ; Wed, 16 Jul 2014 13:49:59 +0000 (UTC) Received: (qmail 511 invoked by uid 500); 16 Jul 2014 13:49:59 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 455 invoked by uid 500); 16 Jul 2014 13:49:59 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 423 invoked by uid 99); 16 Jul 2014 13:49:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jul 2014 13:49:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0CADB1DB6BF; Wed, 16 Jul 2014 13:49:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8167006511808070043==" MIME-Version: 1.0 Subject: Re: Review Request 23510: Fix docker usage unit test From: "Mesos ReviewBot" To: "Benjamin Hindman" , "Yifan Gu" Cc: "Mesos ReviewBot" , "Timothy Chen" , "mesos" Date: Wed, 16 Jul 2014 13:49:47 -0000 Message-ID: <20140716134947.24004.24266@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/23510/ X-Sender: "Mesos ReviewBot" References: <20140715175954.14170.26343@reviews.apache.org> In-Reply-To: <20140715175954.14170.26343@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============8167006511808070043== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23510/#review47881 ----------------------------------------------------------- Bad patch! Reviews applied: [23510] Failed command: git apply --index 23510.patch Error: error: src/tests/docker_containerizer_tests.cpp: does not exist in index - Mesos ReviewBot On July 15, 2014, 5:59 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23510/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Yifan Gu. > > > Bugs: MESOS-1524 > https://issues.apache.org/jira/browse/MESOS-1524 > > > Repository: mesos-git > > > Description > ------- > > The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards. > This fix mocks out Docker update and ignore all Update calls so it has the same resource limits. > > > Diffs > ----- > > src/tests/docker_containerizer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23510/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============8167006511808070043==--