mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@gmail.com>
Subject Re: Review Request 23507: Added Docker unit test, Docker flag and fixs
Date Wed, 16 Jul 2014 17:30:20 GMT
Sorry about that, didn't know it won't build as I thought it's like
what Ben's said.

Ben's branch should be ready to commit so hopefully with Ben's commits
in there our RBs will go through soon too.

Tim

On Wed, Jul 16, 2014 at 10:03 AM, Benjamin Hindman <benh@berkeley.edu> wrote:
> Remind me how review bot operates again? Why can't we apply the parent diff
> and then the actual diff and just build that? If the review has everything
> it needs and is buildable, it would be nice if we can just build it.
>
>
> On Wed, Jul 16, 2014 at 9:59 AM, Vinod Kone <vinodkone@gmail.com> wrote:
>>
>> Hey Tim and Ben,
>>
>> Looks like most of the docker reviews are being flagged as bad patches by
>> the review bot. I'm guessing this is because these patches are based off
>> benh's branch that doesn't exist on HEAD?
>>
>> How do we stop this noise? The easiest solution is to get benh's branch
>> committed. If that's not ready yet, please don't set the group field to
>> "mesos" in the docker reviews, so that review bot won't run on them.
>>
>>
>> On Wed, Jul 16, 2014 at 9:49 AM, Mesos ReviewBot <dev@mesos.apache.org>
>> wrote:
>>>
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/23507/#review47899
>>> -----------------------------------------------------------
>>>
>>>
>>> Bad patch!
>>>
>>> Reviews applied: [23507]
>>>
>>> Failed command: git apply --index 23507.patch
>>>
>>> Error:
>>>  error: src/docker/docker.hpp: does not exist in index
>>> error: src/docker/docker.cpp: does not exist in index
>>> error: patch failed: src/slave/containerizer/containerizer.cpp:169
>>> error: src/slave/containerizer/containerizer.cpp: patch does not apply
>>> error: src/slave/containerizer/docker.hpp: does not exist in index
>>> error: src/slave/containerizer/docker.cpp: does not exist in index
>>> error: patch failed: src/slave/flags.hpp:339
>>> error: src/slave/flags.hpp: patch does not apply
>>> error: patch failed: src/slave/slave.cpp:2426
>>> error: src/slave/slave.cpp: patch does not apply
>>> error: src/tests/docker_containerizer_tests.cpp: does not exist in index
>>> error: patch failed: src/tests/environment.cpp:129
>>> error: src/tests/environment.cpp: patch does not apply
>>>
>>>
>>> - Mesos ReviewBot
>>>
>>>
>>> On July 15, 2014, 5:56 p.m., Timothy Chen wrote:
>>> >
>>> > -----------------------------------------------------------
>>> > This is an automatically generated e-mail. To reply, visit:
>>> > https://reviews.apache.org/r/23507/
>>> > -----------------------------------------------------------
>>> >
>>> > (Updated July 15, 2014, 5:56 p.m.)
>>> >
>>> >
>>> > Review request for mesos, Benjamin Hindman and Yifan Gu.
>>> >
>>> >
>>> > Bugs: MESOS-1524
>>> >     https://issues.apache.org/jira/browse/MESOS-1524
>>> >
>>> >
>>> > Repository: mesos-git
>>> >
>>> >
>>> > Description
>>> > -------
>>> >
>>> > Added first Docker launch unit test, Docker flag into tests and slace
>>> > and fix issues found with test.
>>> >
>>> >
>>> > Diffs
>>> > -----
>>> >
>>> >   src/docker/docker.hpp PRE-CREATION
>>> >   src/docker/docker.cpp PRE-CREATION
>>> >   src/slave/containerizer/containerizer.cpp
>>> > 1b71f33b430645300d171eadc9f7de96d28adf60
>>> >   src/slave/containerizer/docker.hpp PRE-CREATION
>>> >   src/slave/containerizer/docker.cpp PRE-CREATION
>>> >   src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25
>>> >   src/slave/slave.cpp e81abb2e6371d052151253172a4abde7169cb72f
>>> >   src/tests/docker_containerizer_tests.cpp PRE-CREATION
>>> >   src/tests/environment.cpp 434b3f7f890ad05c90c88be796996828e0ac4876
>>> >   src/tests/flags.hpp a003e7fca5e7461cdbb5c62ff9909a287d1b3bd7
>>> >
>>> > Diff: https://reviews.apache.org/r/23507/diff/
>>> >
>>> >
>>> > Testing
>>> > -------
>>> >
>>> > make check
>>> >
>>> >
>>> > Thanks,
>>> >
>>> > Timothy Chen
>>> >
>>> >
>>>
>>
>

Mime
View raw message