mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20499: Converted os::ls to return a Try
Date Tue, 29 Jul 2014 23:53:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/#review49055
-----------------------------------------------------------

Ship it!


Looks great!


3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp
<https://reviews.apache.org/r/20499/#comment85883>

    s/;/./ ?


- Ben Mahler


On July 29, 2014, 6:42 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20499/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 6:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1237
>     https://issues.apache.org/jira/browse/MESOS-1237
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp e916f027e1c9918ec4f2d41e03926c10a1080bca

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp cf2215a90d6e2673085293b8eaf5a44418da3bf0

>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp c5509632988401ee96ed2471c7278c8e164800d7

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346346a33a05fbcd30a11053948eedba4764

> 
> Diff: https://reviews.apache.org/r/20499/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message