mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 23700: Added 'timed_tests.sh' script to help investigate the cause of hanging tests.
Date Tue, 29 Jul 2014 18:39:21 GMT


> On July 28, 2014, 4:05 p.m., Dominic Hamon wrote:
> > support/timed_tests.sh, line 9
> > <https://reviews.apache.org/r/23700/diff/2/?file=643965#file643965line9>
> >
> >     this might be simplified:
> >     
> >     MAKE='make' GTEST_FILTER='Master*' timed_tests.sh 3600
> >     
> >     ie - we assume we're running:
> >     
> >     ${MAKE} GTEST_FILTER=''
> >     ${MAKE} check GTEST_FILTER=${GTEST_FILTER}
> >     
> >     then the user can override the make flags and the tests run, but the default
just does the right thing.

Yeah I was just adding a little more flexibility so that the user can
- skip the separate 'make' stage using [-m] (e.g., if it's already compiled or someone wants
to lump together the make stage into the timeout window).
- use other more specific test commands such as "./mesos-tests.sh --gtest_filter=*XYZ* --gtest_repeat=-1".
Note that you current cannot do 'make check GTEST_FILTER=-1' because it will get stuck at
stout test in an infinite loop.

Anyway, of course these are use cases that no one else requested but I took the liberty to
add them while figuring out the process hierarchy of the tests.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/#review48925
-----------------------------------------------------------


On July 28, 2014, 3:53 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23700/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 3:53 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon and Jie Yu.
> 
> 
> Bugs: MESOS-1559
>     https://issues.apache.org/jira/browse/MESOS-1559
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Example usage:
> 
> ./support/timed_tests.sh -m "make check GTEST_FILTER=" "MESOS_VERBOSE=1 make check GTEST_SHUFFLE=1"
$((120 * 60))
> 
> # Bypass the 'make' stage.
> ./support/timed_tests.sh "MESOS_VERBOSE=1 make check GTEST_SHUFFLE=1" 3600
> 
> It works by setting a new sid for the test script so that all subprocesses are in this
new session.
> 
> 
> Diffs
> -----
> 
>   support/timed_tests.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23700/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux with and without Jenkins.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message