mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 20494: Mesos converted to use Try<Nothing> returns from stout/os.hpp.
Date Tue, 29 Jul 2014 12:33:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/#review48982
-----------------------------------------------------------


Bad patch!

Reviews applied: [20493, 20494]

Failed command: ./support/mesos-style.py

Error:
 Checking 494 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:727:  Lines should be <= 80 characters
long  [whitespace/line_length] [2]
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:734:  Lines should be <= 80 characters
long  [whitespace/line_length] [2]
Total errors found: 2


- Mesos ReviewBot


On July 28, 2014, 10:33 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20494/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 10:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1236
>     https://issues.apache.org/jira/browse/MESOS-1236
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 
>   src/slave/containerizer/mesos/launch.cpp 2db1c7a16905ea24435fd33a4037f69697755813 
>   src/tests/log_tests.cpp b60577d8ee43a4ae94357139e8dfad9eac67a83a 
>   src/tests/script.cpp 15a6542e5d24e3983f920918b0ab62d35c458411 
>   src/tests/utils.cpp 05ef3058b6a1e1daa16351787831687342462eba 
> 
> Diff: https://reviews.apache.org/r/20494/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message