mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20493: Converted bool returns to Try<Nothing> in stout/os.hpp.
Date Mon, 28 Jul 2014 21:26:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20493/#review48910
-----------------------------------------------------------

Ship it!


Great, looks like os::getenv is the only remaining LOG culprit now!

- Ben Mahler


On July 28, 2014, 7:12 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20493/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 7:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1236
>     https://issues.apache.org/jira/browse/MESOS-1236
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 08251724fbe45431db2c3637c6beec81f5744c4c

> 
> Diff: https://reviews.apache.org/r/20493/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message