mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 22796: Add timeout to rescind unused offers
Date Mon, 28 Jul 2014 20:34:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22796/
-----------------------------------------------------------

(Updated July 28, 2014, 8:34 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.


Bugs: MESOS-186
    https://issues.apache.org/jira/browse/MESOS-186


Repository: mesos-git


Description
-------

Based on Kapil's patch (https://reviews.apache.org/r/22066/), adding timeout for each offer
from master to remove the offer when it's no longer used.


Diffs (updated)
-----

  src/master/flags.hpp 32704ce 
  src/master/master.hpp d8a4d9e 
  src/master/master.cpp 273a516 
  src/tests/master_tests.cpp 5a1cf7f 

Diff: https://reviews.apache.org/r/22796/diff/


Testing
-------

Added three more unit tests from Kapil's patch: Testing offer not rescinded after task launched,
offer not rescinded when framework/slave unregistered.
The test exposed a race condition that can lead to a segfault if two remove offers are called
on the same offer.

make check.


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message