mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 23911: multihashmap.getKey() method (useful for fixing MESOS-947)
Date Sat, 26 Jul 2014 11:25:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23911/#review48804
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23911]

All tests passed.

- Mesos ReviewBot


On July 25, 2014, 12:40 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23911/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 12:40 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-947
>     https://issues.apache.org/jira/browse/MESOS-947
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Small extension of stout that is useful for fixing MESOS-947, but also in general. adding
a getKey() method to multihashmap, which finds a key given a value in the map.
> 
> A dependent Mesos patch fixing MESOS-947 will follow promptly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp ecda6a9 
> 
> Diff: https://reviews.apache.org/r/23911/diff/
> 
> 
> Testing
> -------
> 
> The method behaves as expected in the unit test for MESOS-947. I did not create stout
unit tests for it. (There is no precedence for testing multihashmap and this particular piece
of code is very straightforward.)
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message