mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Hansen-Sturm" <cr...@mesosphere.io>
Subject Review Request 23913: Add C++11 (and boost) <atomic> support to stout
Date Fri, 25 Jul 2014 01:17:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23913/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Bugs: MESOS-1626
    https://issues.apache.org/jira/browse/MESOS-1626


Repository: mesos-git


Description
-------

This patch adds support for C++11 (and boost) <atomic> support to stout, following the
pattern in stout/lambda.hpp stout/memory.hpp

However, to support pre-c+11 compilation, boost/atomic is used for the fallback case, as there
is no std::TR1 support.

Note:  with this fix, we still need to incorporate additional boost/atomic headers (either
via a patch, or a more general mechanism.  Still waiting to hear back from Timothy St. Clair
about the proper staging).


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/atomic.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23913/diff/


Testing
-------

make check

compiled and ran all boost "lock free" sample-usage code specified at http://www.boost.org/doc/libs/1_54_0/doc/html/atomic/usage_examples.html.
  These samples compile and ran without modification (for both c++11 and boost).


Thanks,

Craig Hansen-Sturm


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message