mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 23867: Handle discards on the master detection futures.
Date Thu, 24 Jul 2014 02:55:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23867/
-----------------------------------------------------------

(Updated July 24, 2014, 2:55 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Used a WeakFuture to break the cyclic dependency.


Bugs: MESOS-1529
    https://issues.apache.org/jira/browse/MESOS-1529


Repository: mesos-git


Description
-------

In order to trigger re-detections in the slave, we need to be able to discard the Future returned
from detect(). This adds discard support to detect().


Diffs (updated)
-----

  src/master/detector.cpp a34cc211941972e2d64802d5c7ed3f5026229744 
  src/tests/master_contender_detector_tests.cpp 231648d3c564f9a38937b844459c08f0fdd66a92 

Diff: https://reviews.apache.org/r/23867/diff/


Testing
-------

Updated the existing tests.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message