mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 23745: Unnecessary includes and inline definitions from RR 18295
Date Tue, 22 Jul 2014 18:13:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23745/
-----------------------------------------------------------

(Updated July 22, 2014, 6:13 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Dominic Hamon.


Bugs: MESOS-1583
    https://issues.apache.org/jira/browse/MESOS-1583


Repository: mesos-git


Description
-------

Dominic's Hamon review request: https://reviews.apache.org/r/18295 mergeable to today's master
version, this is a lightened version to make review easier.
Note I see an improvements of ~7.5% of the compile time.


Diffs (updated)
-----

  include/mesos/resources.hpp 8fc347e 
  src/Makefile.am c216e2f 
  src/common/attributes.hpp e6271cd 
  src/common/attributes.cpp 851c92a 
  src/common/date_utils.hpp 523e273 
  src/common/date_utils.cpp 1c7565d 
  src/common/factory.hpp 94056f6 
  src/common/http.hpp 717bbe9 
  src/common/http.cpp e81a7ad 
  src/common/parse.hpp 4eb5096 
  src/common/protobuf_utils.hpp 0341c7f 
  src/common/protobuf_utils.cpp PRE-CREATION 
  src/common/resources.cpp d39001b 
  src/common/status_utils.hpp 1980551 
  src/common/thread.hpp 7e48724 
  src/common/thread.cpp PRE-CREATION 
  src/common/type_utils.hpp ee946a3 
  src/common/type_utils.cpp PRE-CREATION 
  src/common/values.cpp 15583fd 
  src/master/master.cpp 152ea7d 
  src/slave/containerizer/isolator.hpp 8c05cd4 
  src/slave/slave.cpp 6f0e121 

Diff: https://reviews.apache.org/r/23745/diff/


Testing
-------


Thanks,

Isabel Jimenez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message