mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 23701: Generate u32 filter handle in user level to work around MESOS-1617.
Date Mon, 21 Jul 2014 17:13:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23701/#review48254
-----------------------------------------------------------

Ship it!


Ship It!

- Cong Wang


On July 18, 2014, 11:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23701/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 11:57 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
> 
> 
> Bugs: MESOS-1617
>     https://issues.apache.org/jira/browse/MESOS-1617
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See ticket. I introduced a Handle class in routing::filter. To workaround, I mimic the
kernel logic to generate handles (except that I fixed the bug) and set the handle explicitly.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/arp.cpp c18aebb 
>   src/linux/routing/filter/filter.hpp 40e21db 
>   src/linux/routing/filter/handle.hpp PRE-CREATION 
>   src/linux/routing/filter/icmp.cpp 8e6f013 
>   src/linux/routing/filter/internal.hpp 6836d1f 
>   src/linux/routing/filter/ip.hpp 11e417d 
>   src/linux/routing/filter/ip.cpp 43f1f7f 
>   src/tests/routing_tests.cpp dcc4982 
> 
> Diff: https://reviews.apache.org/r/23701/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> sudo bin/mesos-tests.sh --gtest_filter=*Routing* --gtest_repeat=100
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message