mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 23513: Implemented launching executors in DockerContainerizer.
Date Mon, 21 Jul 2014 13:49:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23513/#review48215
-----------------------------------------------------------



src/docker/docker.cpp
<https://reviews.apache.org/r/23513/#comment84568>

    I wouldn't default the --net=host, this could have a lot of unintended consequences. 


- Timothy St. Clair


On July 17, 2014, 6:21 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23513/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 6:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch allows launching executors in Docker image.
> 
> Also added a test Docker image that embeds a test executor and automatically installs
if it's not found in local Docker.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a1fe9dc2173d8e23398edfce6ef7dc458a3c81bb 
>   src/docker/docker.hpp PRE-CREATION 
>   src/docker/docker.cpp PRE-CREATION 
>   src/slave/containerizer/docker.cpp PRE-CREATION 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
>   src/tests/environment.cpp 434b3f7f890ad05c90c88be796996828e0ac4876 
>   src/tests/mesos_test_executor_docker_image/Dockerfile PRE-CREATION 
>   src/tests/mesos_test_executor_docker_image/install.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23513/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message