mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 23520: Send healthy status when task killed after health check
Date Wed, 16 Jul 2014 21:08:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23520/#review47943
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 16, 2014, 7:54 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23520/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 7:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently after the health check receives configured amount of task fails it will initiate
a kill task.
> However currently the task kill status update doesn't set the healthy field so it's unclear
was it killed because health check or other reasons.
> This patch sets the health check field when the task is killed because of failing health
checks.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp a573637 
>   src/tests/health_check_tests.cpp 44711fd 
> 
> Diff: https://reviews.apache.org/r/23520/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message