mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 23464: Properly iterate through composing containerizers.
Date Wed, 16 Jul 2014 18:38:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23464/#review47927
-----------------------------------------------------------


Would you mind explaining why do this change? Does the previous version has a bug?

Also, I think we need some tests for the new composing containerizer?

- Jie Yu


On July 14, 2014, 10:31 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23464/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 10:31 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-1527
>     https://issues.apache.org/jira/browse/MESOS-1527
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary and dependent review 23462.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23464/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message