mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 23443: Re-enable health check tests
Date Wed, 16 Jul 2014 17:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23443/
-----------------------------------------------------------

(Updated July 16, 2014, 5:30 p.m.)


Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Niklas Nielsen.


Bugs: MESOS-1533
    https://issues.apache.org/jira/browse/MESOS-1533


Repository: mesos-git


Description
-------

Currently the health check tests are disabled as it was flaky. Part of the reason is that
all assertions was EXPECTs instead of ASSERTs so it will continue to execute. 
Another issue was it's currently discovering the path to launch health check executable from
the command executor main argv[0] path.
However, the correct path is to launch the generated script that does library path resolution,
which is the parent of .libs.


Diffs (updated)
-----

  src/launcher/executor.cpp a573637 
  src/tests/health_check_tests.cpp 44711fd 

Diff: https://reviews.apache.org/r/23443/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message