mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 23510: Fix docker usage unit test
Date Wed, 16 Jul 2014 13:49:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/#review47881
-----------------------------------------------------------


Bad patch!

Reviews applied: [23510]

Failed command: git apply --index 23510.patch

Error:
 error: src/tests/docker_containerizer_tests.cpp: does not exist in index


- Mesos ReviewBot


On July 15, 2014, 5:59 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23510/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 5:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The Docker usage test breaks since we launch a Docker with given resource limits but
when we test usage it will get different limits as Docker update changes it afterwards.
> This fix mocks out Docker update and ignore all Update calls so it has the same resource
limits.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23510/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message