mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 23543: Fixed a flaky test.
Date Wed, 16 Jul 2014 03:40:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23543/#review47855
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 16, 2014, 3:16 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23543/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 3:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1603
>     https://issues.apache.org/jira/browse/MESOS-1603
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This test was sending a ShutdownMessage() to the slave. Now that the slave unregisters
itself when shutting itself down, this test was inducing a Registar operation to remove the
slave. When the clock was advanced the registrar operation would immediately cause the master
to fail.
> 
> The fix here was to tell the slave that this message is coming from the master.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp d6cfe4ddd479dee77c488eae40ab6899d5d03312 
>   src/tests/slave_tests.cpp 371a5b8eb3d15343418d83d8cf08591649ac807c 
> 
> Diff: https://reviews.apache.org/r/23543/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message