mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 23525: Checked IP header length for IP packet filters.
Date Tue, 15 Jul 2014 21:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23525/#review47823
-----------------------------------------------------------

Ship it!


lgtm. someone else should also take a look at the magic vals.

- Chi Zhang


On July 15, 2014, 9:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23525/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Vinod Kone, and Cong Wang.
> 
> 
> Bugs: MESOS-1600
>     https://issues.apache.org/jira/browse/MESOS-1600
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. Since we currently hard code src/dest port offset, we need to make sure
the IP packet does not contain options.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/ip.cpp 2623deb 
> 
> Diff: https://reviews.apache.org/r/23525/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message