mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Review Request 23518: Fix executor passing STDIN pipe to health check
Date Tue, 15 Jul 2014 19:33:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23518/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

Previous fix for STDIN only fixes the health check command not passing in STDIN pipe by reading
file STDIN.
However the health check command is still getting STDIN piped as the command executor is creating
a PIPE to STDIN when launching health check.
To really fix this we need to also fix not passing anything to STDIN when launching health
check.


Diffs
-----

  src/launcher/executor.cpp 9c80848 

Diff: https://reviews.apache.org/r/23518/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message