mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 23414: Unbundling of libev
Date Tue, 15 Jul 2014 18:18:59 GMT


> On July 15, 2014, 5:47 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 146
> > <https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line146>
> >
> >     Sorry for jumping in late, but is there a way to check the "EV_CHILD_ENABLE"
condition at configure time? I'm afraid users will easily miss this warning among all the
lines that configure spews which will later cause hard to debug errors.

'make check' also fails in glorious fashion. 

Perhaps we should update the instructions on how to build w/--disable-bundled?  
 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23414/#review47784
-----------------------------------------------------------


On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23414/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 4:16 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1172
>     https://issues.apache.org/jira/browse/MESOS-1172
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable mesos to build against the system installed version of libev.  
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 429c956 
>   3rdparty/libprocess/Makefile.am 87cf1ae 
>   3rdparty/libprocess/configure.ac 27c6ede 
> 
> Diff: https://reviews.apache.org/r/23414/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message