mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 23416: Fix health check command subprocess handling
Date Fri, 11 Jul 2014 20:45:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23416/
-----------------------------------------------------------

(Updated July 11, 2014, 8:45 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.


Bugs: MESOS-1577
    https://issues.apache.org/jira/browse/MESOS-1577


Repository: mesos-git


Description
-------

Fix health check command subprocess handling.

Currently it doesn't check all subprocess future states, and also creates a pipe to stdin
which can cause some scripts to expect stdin input and blocks.


Diffs (updated)
-----

  src/health-check/main.cpp 707810a 

Diff: https://reviews.apache.org/r/23416/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message