mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexandra Sava" <alexandrasav...@gmail.com>
Subject Re: Review Request 23147: Rename slaves/frameworks activated/deactivated
Date Fri, 11 Jul 2014 13:28:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/
-----------------------------------------------------------

(Updated July 11, 2014, 1:28 p.m.)


Review request for mesos, Adam B and Ben Mahler.


Bugs: MESOS-1188
    https://issues.apache.org/jira/browse/MESOS-1188


Repository: mesos-git


Description
-------

The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated".
Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated"
map holds both activated and deactivated frameworks.
In order to make things look clear, rename the following:
* master.slaves.deactivated -> master.slaves.removed
* master.slaves.activated -> master.slaves.registered
* master.frameworks.activated -> master.frameworks.registered
* allocator.slaveDisconnect -> allocator.slaveDeactivate
* allocator.slaveReconnected -> allocator.slaveReactivated


Diffs (updated)
-----

  src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
  src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
  src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
  src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
  src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
  src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
  src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
  src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
  src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
  src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
  src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 

Diff: https://reviews.apache.org/r/23147/diff/


Testing
-------


Thanks,

Alexandra Sava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message