mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint
Date Mon, 07 Jul 2014 23:44:14 GMT


> On July 7, 2014, 10:03 p.m., Adam B wrote:
> > src/master/http.cpp, lines 622-623
> > <https://reviews.apache.org/r/22832/diff/3/?file=625040#file625040line622>
> >
> >     Does this mean that the /shutdown API only works when authentication is enabled
(or at least credentials are provided)? What if I just want to /shutdown on my local test
cluster? Shouldn't there be a way to allow /shutdown without authentication?

This is a good point, let's circle back to this in a follow up review Isabel.


> On July 7, 2014, 10:03 p.m., Adam B wrote:
> > src/master/http.cpp, line 637
> > <https://reviews.apache.org/r/22832/diff/3/?file=625040#file625040line637>
> >
> >     Can we get some more descriptive error strings, please? ("Mesos master" everywhere
may not be descriptive enough when debugging)

This is actually the "realm", not an error message. Do you have a suggestion for a better
realm? Thinking about Kerberos, what constraints will we have on the realm (e.g., no spaces)?


> On July 7, 2014, 10:03 p.m., Adam B wrote:
> > src/slave/slave.hpp, line 341
> > <https://reviews.apache.org/r/22832/diff/3/?file=625044#file625044line341>
> >
> >     Why did the const Slave& have to become a Slave* too?

Done for consistency, since we've also used * for nested classes in other places (the Master::Http
and Slave::Http classes were the only remaining ones that I was aware of that didn't pass
a *).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22832/#review47417
-----------------------------------------------------------


On July 7, 2014, 8:59 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22832/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 8:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1390
>     https://issues.apache.org/jira/browse/MESOS-1390
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> HTTP Authenticated '/shutdown' endpoint for shutting down a running framework
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e3ff6d7 
>   src/master/http.cpp 5d86976 
>   src/master/master.hpp 5fef354 
>   src/master/master.cpp 251b699 
>   src/slave/http.cpp cd7f692 
>   src/slave/slave.hpp 605ee4a 
>   src/slave/slave.cpp f42ab60 
>   src/tests/shutdown_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22832/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message