mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yifan Gu" <yi...@mesosphere.io>
Subject Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
Date Sun, 06 Jul 2014 22:56:18 GMT


> On July 3, 2014, 7:37 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1012
> > <https://reviews.apache.org/r/22313/diff/12/?file=621579#file621579line1012>
> >
> >     Where did "42" hours come from? IIUC, you want to ensure the task wasn't launched
because the update is pending?
> >     
> >     One way to do it is to catch the _runTask() dispatch and do a clock::settle().
If the slave were to not wait for update() to finish (which it won't since you fixed it) then
scheduler should have got the status update after settling the clock. You can ensure this
by ASSERT(status2.isPending()). Does that make sense?

Thanks a lot! Will try this later, but unfortunately, I think I will have to put off this
patch for a week...


> On July 3, 2014, 7:37 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1071
> > <https://reviews.apache.org/r/22313/diff/12/?file=621579#file621579line1071>
> >
> >     ditto. move the expectation for offers2 down.

Will do.


- Yifan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review47311
-----------------------------------------------------------


On July 1, 2014, 8:33 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22313/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 8:33 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-886
>     https://issues.apache.org/jira/browse/MESOS-886
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added __runTask() to wait for the completion of containerizer->update() and check
the result before sending RunTaskMessage.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 605ee4a 
>   src/slave/slave.cpp f42ab60 
>   src/tests/slave_tests.cpp 371a5b8 
> 
> Diff: https://reviews.apache.org/r/22313/diff/
> 
> 
> Testing
> -------
> 
> SlaveTest, CancelTaskIfContainerizerFails
> 
> Which tests that if the containerizer->update() return a Failure, the task won't be
launched and the scheduler will get TASK_LOST.
> 
> make check
> 
> 
> File Attachments
> ----------------
> 
> framework will exit
>   https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
> log
>   https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message