Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26B1611316 for ; Fri, 6 Jun 2014 17:46:03 +0000 (UTC) Received: (qmail 52493 invoked by uid 500); 6 Jun 2014 17:46:03 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 52446 invoked by uid 500); 6 Jun 2014 17:46:03 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 52435 invoked by uid 99); 6 Jun 2014 17:46:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jun 2014 17:46:02 +0000 Date: Fri, 6 Jun 2014 17:46:02 +0000 (UTC) From: "Dominic Hamon (JIRA)" To: dev@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-1459) Build failure: Ubuntu 13.10/clang due to missing virtual destructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020121#comment-14020121 ] Dominic Hamon commented on MESOS-1459: -------------------------------------- commit 10a9dac59a5a03809e2fe31c81983d96f7eb275e Author: Dominic Hamon Commit: Jie Yu Added virtual destructor to Operation base class. Review: https://reviews.apache.org/r/22311 > Build failure: Ubuntu 13.10/clang due to missing virtual destructor > ------------------------------------------------------------------- > > Key: MESOS-1459 > URL: https://issues.apache.org/jira/browse/MESOS-1459 > Project: Mesos > Issue Type: Bug > Components: build > Reporter: Dominic Hamon > Assignee: Dominic Hamon > > In file included from launcher/main.cpp:19: > In file included from ./launcher/launcher.hpp:24: > In file included from ../3rdparty/libprocess/include/process/future.hpp:23: > ../3rdparty/libprocess/include/process/owned.hpp:188:5: error: delete called on 'mesos::internal::launcher::Operation' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] > delete t; > ^ > /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:456:8: note: in instantiation of member function 'process::Owned::Data::~Data' requested here > delete __p; > ^ > /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:768:24: note: in instantiation of function template specialization 'std::__shared_count<2>::__shared_count::Data *>' requested here > : _M_ptr(__p), _M_refcount(__p) > ^ > /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:919:4: note: in instantiation of function template specialization 'std::__shared_ptr::Data, 2>::__shared_ptr::Data>' requested here > __shared_ptr(__p).swap(*this); > ^ > ../3rdparty/libprocess/include/process/owned.hpp:68:10: note: in instantiation of function template specialization 'std::__shared_ptr::Data, 2>::reset::Data>' requested here > data.reset(new Data(t)); > ^ > ./launcher/launcher.hpp:101:7: note: in instantiation of member function 'process::Owned::Owned' requested here > add(process::Owned(new T())); > ^ > launcher/main.cpp:26:3: note: in instantiation of function template specialization 'mesos::internal::launcher::add' requested here > launcher::add(); > ^ > 1 error generated. -- This message was sent by Atlassian JIRA (v6.2#6252)