Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1925111F88 for ; Mon, 30 Jun 2014 14:22:55 +0000 (UTC) Received: (qmail 70228 invoked by uid 500); 30 Jun 2014 14:22:54 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 70169 invoked by uid 500); 30 Jun 2014 14:22:54 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 70155 invoked by uid 99); 30 Jun 2014 14:22:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2014 14:22:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9AFF51DB42A; Mon, 30 Jun 2014 14:22:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6321415462944467976==" MIME-Version: 1.0 Subject: Re: Review Request 22367: Second phase: Mesos-slave support for "node drain" From: "Mesos ReviewBot" To: "Ben Mahler" Cc: "Mesos ReviewBot" , "mesos" , "Alexandra Sava" Date: Mon, 30 Jun 2014 14:22:43 -0000 Message-ID: <20140630142243.5201.57274@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/22367/ X-Sender: "Mesos ReviewBot" References: <20140630133844.5201.49883@reviews.apache.org> In-Reply-To: <20140630133844.5201.49883@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============6321415462944467976== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46979 ----------------------------------------------------------- Patch looks great! Reviews applied: [22367] All tests passed. - Mesos ReviewBot On June 30, 2014, 1:38 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22367/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 1:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-544 > https://issues.apache.org/jira/browse/MESOS-544 > > > Repository: mesos-git > > > Description > ------- > > Second phase: Mesos-slave support for "node drain" > * send UnregisterRequest message to the master > * test that the message is being delivered to the master > > ** This review relies on https://reviews.apache.org/r/21379/ > > > Diffs > ----- > > src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 > src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8 > src/slave/slave.cpp f42ab60f29f38bcd8857f72fde9fc77cbfc36dde > src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e > > Diff: https://reviews.apache.org/r/22367/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > > --===============6321415462944467976==--