Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 032C6116A9 for ; Tue, 24 Jun 2014 21:53:10 +0000 (UTC) Received: (qmail 63084 invoked by uid 500); 24 Jun 2014 21:53:09 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 63022 invoked by uid 500); 24 Jun 2014 21:53:09 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 63008 invoked by uid 99); 24 Jun 2014 21:53:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jun 2014 21:53:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D16951DB27C; Tue, 24 Jun 2014 21:52:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4771736647935202123==" MIME-Version: 1.0 Subject: Re: Review Request 22945: Fixed FrameworkReregistersFirst and SlaveReregistersFirst allocator tests. From: "Dominic Hamon" To: "Jiang Yan Xu" , "Dominic Hamon" Cc: "Vinod Kone" , "mesos" Date: Tue, 24 Jun 2014 21:52:58 -0000 Message-ID: <20140624215258.22603.89958@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/22945/ X-Sender: "Dominic Hamon" References: <20140624215003.22603.65757@reviews.apache.org> In-Reply-To: <20140624215003.22603.65757@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos-git --===============4771736647935202123== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22945/#review46584 ----------------------------------------------------------- Ship it! Ship It! - Dominic Hamon On June 24, 2014, 2:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22945/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 2:50 p.m.) > > > Review request for mesos, Dominic Hamon and Jiang Yan Xu. > > > Bugs: MESOS-1514 and MESOS-1532 > https://issues.apache.org/jira/browse/MESOS-1514 > https://issues.apache.org/jira/browse/MESOS-1532 > > > Repository: mesos-git > > > Description > ------- > > The bug was that the tests were not waiting for acks to be received by slave causing the slave to retry on master failover. > > > Diffs > ----- > > src/tests/allocator_zookeeper_tests.cpp 1f15cf5312e67774a7dc4443d605e45103601343 > > Diff: https://reviews.apache.org/r/22945/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="*ReregistersFirst*" --gtest_break_on_failure --gtest_repeat=-1 --verbose > > > Thanks, > > Vinod Kone > > --===============4771736647935202123==--