Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71BAC11F9F for ; Tue, 24 Jun 2014 18:55:49 +0000 (UTC) Received: (qmail 26118 invoked by uid 500); 24 Jun 2014 18:55:49 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 26059 invoked by uid 500); 24 Jun 2014 18:55:49 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 26045 invoked by uid 99); 24 Jun 2014 18:55:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jun 2014 18:55:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 76BB21DB26A; Tue, 24 Jun 2014 18:55:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0579984300837874017==" MIME-Version: 1.0 Subject: Re: Review Request 22714: Added a test to verify that frameworks with equal share get equal number of allocations. From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Tue, 24 Jun 2014 18:55:38 -0000 Message-ID: <20140624185538.22595.67258@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/22714/ X-Sender: "Ben Mahler" References: <20140618014851.6311.94256@reviews.apache.org> In-Reply-To: <20140618014851.6311.94256@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============0579984300837874017== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22714/#review46565 ----------------------------------------------------------- Ship it! src/tests/allocator_tests.cpp where is the closing paren? :) - Ben Mahler On June 18, 2014, 1:48 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22714/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 1:48 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1187 > https://issues.apache.org/jira/browse/MESOS-1187 > > > Repository: mesos-git > > > Description > ------- > > I wrote this test because to see if I can repro the issue in MESOS-1187 (there's also an existing TODO). Unfortunately couldn't repro the behavior, but this would be a good regression test to have. > > > Diffs > ----- > > src/tests/allocator_tests.cpp 7ad496437cec6238f208225a012030b7f3c8fe84 > src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4 > > Diff: https://reviews.apache.org/r/22714/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============0579984300837874017==--