Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E35711B6C for ; Thu, 12 Jun 2014 21:50:45 +0000 (UTC) Received: (qmail 27200 invoked by uid 500); 12 Jun 2014 21:50:45 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 27144 invoked by uid 500); 12 Jun 2014 21:50:45 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 27130 invoked by uid 99); 12 Jun 2014 21:50:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2014 21:50:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 28DE61D9F45; Thu, 12 Jun 2014 21:50:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7617364000151027216==" MIME-Version: 1.0 Subject: Re: Review Request 20963: Add a cgroup perf_event isolator. From: "Ian Downes" To: "Vinod Kone" Cc: "Mesos ReviewBot" , "Benjamin Hindman" , "mesos" , "Ian Downes" Date: Thu, 12 Jun 2014 21:50:35 -0000 Message-ID: <20140612215035.22323.80387@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Downes" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/20963/ X-Sender: "Ian Downes" References: <20140609050842.22323.84450@reviews.apache.org> In-Reply-To: <20140609050842.22323.84450@reviews.apache.org> Reply-To: "Ian Downes" X-ReviewRequest-Repository: mesos-git --===============7617364000151027216== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20963/ ----------------------------------------------------------- (Updated June 12, 2014, 9:50 p.m.) Review request for mesos and Vinod Kone. Changes ------- i'll shepherd this -- vinod. Repository: mesos-git Description ------- This isolator only creates the perf_event cgroup and places the executor into the cgroup; no performance statistics are gathered/exported. NOTE: The recover() as implemented is "non-strict"; it will happily recover containers even if they don't have a perf_event cgroup present. This permits restarting the slave to add this isolator. Existing containers will not be isolated. New containers will be isolated. Diffs ----- src/Makefile.am 4a3f2e12643a1f02284587ebcbe9374f416b3d60 src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION Diff: https://reviews.apache.org/r/20963/diff/ Testing ------- Manually tested. Our current testing code does not easily permit testing different combinations of isolators for the MesosContainerizer. Thanks, Ian Downes --===============7617364000151027216==--