Return-Path: 
 <dev-return-26319-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9D80910E4F
	for <apmail-mesos-dev-archive@www.apache.org>;
 Wed,  4 Jun 2014 22:32:55 +0000 (UTC)
Received: (qmail 72597 invoked by uid 500); 4 Jun 2014 22:32:55 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 72538 invoked by uid 500); 4 Jun 2014 22:32:55 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 72525 invoked by uid 99); 4 Jun 2014 22:32:55 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2014 22:32:55 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 77D351D9B0C;
	Wed,  4 Jun 2014 22:32:46 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3361602335943043744=="
MIME-Version: 1.0
Subject: Re: Review Request 22248: Allowed parsing JSON array flags.
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Vinod Kone" <vinodkone@gmail.com>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Jie Yu" <yujie.jay@gmail.com>, "mesos" <dev@mesos.apache.org>
Date: Wed, 04 Jun 2014 22:32:46 -0000
Message-ID: <20140604223246.12449.15666@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/22248/
X-Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20140604222940.12449.49151@reviews.apache.org>
In-Reply-To: <20140604222940.12449.49151@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>
X-ReviewRequest-Repository: mesos-git

--===============3361602335943043744==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22248/#review44766
-----------------------------------------------------------


What was the motivation for this patch?

- Ben Mahler


On June 4, 2014, 10:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22248/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 10:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. I did try to use enable_if to make 'parse' more generic to all JSON values, but its more complicated than I thought. The main reason is because we use lambda::bind(&parse<T>, ...) in 'add(...)' function. The compiler is not quite smart enough to figure out the right overload when doing 'lambda::bind'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 1209469 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
> 
> Diff: https://reviews.apache.org/r/22248/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


--===============3361602335943043744==--