mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-1459) Build failure: Ubuntu 13.10/clang due to missing virtual destructor
Date Fri, 06 Jun 2014 17:46:02 GMT

    [ https://issues.apache.org/jira/browse/MESOS-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020121#comment-14020121
] 

Dominic Hamon commented on MESOS-1459:
--------------------------------------

commit 10a9dac59a5a03809e2fe31c81983d96f7eb275e
Author: Dominic Hamon <dhamon@twopensource.com>
Commit: Jie Yu <yujie.jay@gmail.com>

    Added virtual destructor to Operation base class.
    
    Review: https://reviews.apache.org/r/22311


> Build failure: Ubuntu 13.10/clang due to missing virtual destructor
> -------------------------------------------------------------------
>
>                 Key: MESOS-1459
>                 URL: https://issues.apache.org/jira/browse/MESOS-1459
>             Project: Mesos
>          Issue Type: Bug
>          Components: build
>            Reporter: Dominic Hamon
>            Assignee: Dominic Hamon
>
> In file included from launcher/main.cpp:19:
> In file included from ./launcher/launcher.hpp:24:
> In file included from ../3rdparty/libprocess/include/process/future.hpp:23:
> ../3rdparty/libprocess/include/process/owned.hpp:188:5: error: delete called on 'mesos::internal::launcher::Operation'
that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
>     delete t;
>     ^
> /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:456:8:
note: in instantiation of member function 'process::Owned<mesos::internal::launcher::Operation>::Data::~Data'
requested here
>               delete __p;
>               ^
> /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:768:24:
note: in instantiation of function template specialization 'std::__shared_count<2>::__shared_count<process::Owned<mesos::internal::launcher::Operation>::Data
*>' requested here
>         : _M_ptr(__p), _M_refcount(__p)
>                        ^
> /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/shared_ptr_base.h:919:4:
note: in instantiation of function template specialization 'std::__shared_ptr<process::Owned<mesos::internal::launcher::Operation>::Data,
2>::__shared_ptr<process::Owned<mesos::internal::launcher::Operation>::Data>'
requested here
>           __shared_ptr(__p).swap(*this);
>           ^
> ../3rdparty/libprocess/include/process/owned.hpp:68:10: note: in instantiation of function
template specialization 'std::__shared_ptr<process::Owned<mesos::internal::launcher::Operation>::Data,
2>::reset<process::Owned<mesos::internal::launcher::Operation>::Data>' requested
here
>     data.reset(new Data(t));
>          ^
> ./launcher/launcher.hpp:101:7: note: in instantiation of member function 'process::Owned<mesos::internal::launcher::Operation>::Owned'
requested here
>   add(process::Owned<Operation>(new T()));
>       ^
> launcher/main.cpp:26:3: note: in instantiation of function template specialization 'mesos::internal::launcher::add<mesos::internal::launcher::ShellOperation>'
requested here
>   launcher::add<launcher::ShellOperation>();
>   ^
> 1 error generated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message