mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 23173: Adding missing total frameworks metric.
Date Mon, 30 Jun 2014 19:32:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23173/#review47010
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23173]

All tests passed.

- Mesos ReviewBot


On June 30, 2014, 5:37 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23173/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 5:37 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> total_schedulers from stats.json was never ported to the new metrics endpoint.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 
>   src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8 
>   src/tests/master_tests.cpp 4dc28f261bdd460cde59b699c05cf65a326afd4d 
> 
> Diff: https://reviews.apache.org/r/23173/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message