mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 22367: Second phase: Mesos-slave support for "node drain"
Date Mon, 30 Jun 2014 14:22:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22367/#review46979
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22367]

All tests passed.

- Mesos ReviewBot


On June 30, 2014, 1:38 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22367/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 1:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-544
>     https://issues.apache.org/jira/browse/MESOS-544
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Second phase: Mesos-slave support for "node drain"
> * send UnregisterRequest message to the master
> * test that the message is being delivered to the master
> 
> ** This review relies on https://reviews.apache.org/r/21379/
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 
>   src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8 
>   src/slave/slave.cpp f42ab60f29f38bcd8857f72fde9fc77cbfc36dde 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/22367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message