mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 22825: Split version where N tokens can be specified
Date Sun, 29 Jun 2014 19:51:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22825/#review46953
-----------------------------------------------------------

Ship it!


I simplified as Dominic suggested and submitted this. Great addition, thanks Isabel.

- Benjamin Hindman


On June 26, 2014, 5:49 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22825/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 5:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1522
>     https://issues.apache.org/jira/browse/MESOS-1522
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> SplitN function is stout/strings so we can choose how many tokens we want to retreive
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 08428b8 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp c83156e 
> 
> Diff: https://reviews.apache.org/r/22825/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message