mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 21734: MESOS-390 Handle file:// in fetcher
Date Sat, 28 Jun 2014 05:51:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21734/#review46939
-----------------------------------------------------------


Patch looks great!

Reviews applied: [21734]

All tests passed.

- Mesos ReviewBot


On June 27, 2014, 11:54 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21734/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 11:54 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-390
>     https://issues.apache.org/jira/browse/MESOS-390
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Handling file:// in the fetcher, and also handle case when localhost is used.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9027927 
>   src/launcher/fetcher.cpp c4425eb 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp 5c86fd4 
> 
> Diff: https://reviews.apache.org/r/21734/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to test file:// and file://localhost.
> make check.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message