mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 22852: Refactored the mesos containerizer launcher to fix MESOS-1404.
Date Wed, 25 Jun 2014 21:25:22 GMT


> On June 25, 2014, 8:07 p.m., Benjamin Hindman wrote:
> > Looks good Jie. Any reason not to have a launch.cpp too? Just keeps mesos/containerizer.cpp
smaller.

Added launch.cpp under mesos/


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22852/#review46676
-----------------------------------------------------------


On June 25, 2014, 7:52 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22852/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-1404
>     https://issues.apache.org/jira/browse/MESOS-1404
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. The main idea is to create a new binary called 'mesos-containerizer-helper'
which performs most of the logic of 'execute' in the original code.
> 
> Also, we leverage the new Subprocess interface to handle redirections.
> 
> (BTW: I fixed a few 70 char width comments issue when I doing the refactor).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 861aad2 
>   src/slave/containerizer/containerizer.cpp 922ae17 
>   src/slave/containerizer/launcher.hpp 835d7a9 
>   src/slave/containerizer/launcher.cpp 2b13d1f 
>   src/slave/containerizer/linux_launcher.hpp 622810c 
>   src/slave/containerizer/linux_launcher.cpp 7ebccb4 
>   src/slave/containerizer/mesos/containerizer.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/main.cpp PRE-CREATION 
>   src/slave/containerizer/mesos_containerizer.hpp 21affae 
>   src/slave/containerizer/mesos_containerizer.cpp 76c101c 
>   src/tests/cgroups_isolator_tests.cpp 5a9704d 
>   src/tests/containerizer_tests.cpp 8ea7974 
>   src/tests/isolator_tests.cpp 0bbec09 
>   src/tests/master_tests.cpp 885e0fb 
>   src/tests/mesos.hpp eeb8631 
>   src/tests/mesos.cpp 24af32b 
>   src/tests/slave_tests.cpp 21fe685 
> 
> Diff: https://reviews.apache.org/r/22852/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message