mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 22979: do not append and endln on cgroup write.
Date Wed, 25 Jun 2014 19:29:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46672
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/22979/#comment82218>

    How about
    
    "Recent kernels will cause operations to fail if 'endl' is appended to the control file."
    
    I'm assuming it is backwards compatible with older kernels?


- Vinod Kone


On June 25, 2014, 7:26 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1195
>     https://issues.apache.org/jira/browse/MESOS-1195
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor update to remove the endln appending to cgroup writes.  This causes issues in later
kernels, I uncovered it in rawhide. 
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 5472eb8 
> 
> Diff: https://reviews.apache.org/r/22979/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message