mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 22923: Explicitly terminated scheduler process in ~MesosSchedulerDriver().
Date Tue, 24 Jun 2014 16:27:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22923/#review46538
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On June 23, 2014, 9:50 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22923/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 9:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1534
>     https://issues.apache.org/jira/browse/MESOS-1534
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Without this fix, Mesos tests that have assert failures get deadlocked on ~MesosSchedulerDriver()
(because driver.stop() is not called) waiting forever for the scheduler process to exit. This
causes the tests to never exit.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 869f50a605a6a3d004609443b4c47d8b3a40d23c 
> 
> Diff: https://reviews.apache.org/r/22923/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message